Village casinos: fixes from review #8

Merged
SteamPodEater merged 1 commit from village-casino-fixes into main 2026-11-10 09:06:28 +00:00
Owner

Requested by Rik · project thread

Builds on #7 (base branch village-casino-second-floor). These are fixes from a code review of the village casino PRs #1-#7.

Bugs fixed

  • Player zone blocking an upgrade: a player casino zone could be registered on the ground a village casino grows into, and that blocked the upgrade forever. ZoneEvents.register now refuses it.
  • Neighbouring villages: a new village casino could be placed inside the reserved ground of a neighbouring village's casino. Placement now keeps clear of every placed frame (VillageCasinoEvents.intersectsFrame).
  • Dug holes: the reserved ground now reaches 3 blocks below the floor, the same depth the upgrade check uses. A block placed in a dug hole can no longer block the upgrade.
  • Old casinos: the upgrade check uses the stored zone box as the current building. Before, player blocks above an old, lower casino were not counted and were silently cleared, because the new templates are taller.
  • Stairs: the staircase now ends level with the second floor (one more step in the ceiling layer, with headroom kept). Players and villagers no longer need to jump at the top.
  • Snowy upper floor: with a second floor, the hall ceiling uses floor material. The snowy upper floor was packed ice.
  • Sign names: the "Hot:" sign line uses short game names (e.g. "Jackpot", "Hi-Lo"), so they fit on the sign.
  • Sneak peek: the 1-2 star sneak peek only replaces a machine that has a twin, so no game of the star goes missing.

Improvement

  • Placement retries: each retry looks at other spots (the distance shifts by one and the spread along the village edge grows), and 16 blocks was added as a last distance. Fewer villages should end up without a casino now that the full 5-star site is required.

Not tested in game

Gradle can't reach maven.neoforged.net from the build container. Checked with the generator's validation, the javac syntax check, build_assets.sh and check_trees.py.

🤖 Generated with Claude Code

https://claude.ai/code/session_01MfH3NBzVMUijPYLmpAUPwK

<!-- claude-projects-attribution --> _Requested by **Rik** · [project thread](https://claude.ai/code/project/chan_01GF4aYRVNpT2F67Hfz4fSLG?thread=cmsg_01GF4aYRVNpT2F67Hfz4fSLGMhvpZkiNXCoor32CLK6N17)_ Builds on #7 (base branch `village-casino-second-floor`). These are fixes from a code review of the village casino PRs #1-#7. ## Bugs fixed - **Player zone blocking an upgrade:** a player casino zone could be registered on the ground a village casino grows into, and that blocked the upgrade forever. `ZoneEvents.register` now refuses it. - **Neighbouring villages:** a new village casino could be placed inside the reserved ground of a neighbouring village's casino. Placement now keeps clear of every placed frame (`VillageCasinoEvents.intersectsFrame`). - **Dug holes:** the reserved ground now reaches 3 blocks below the floor, the same depth the upgrade check uses. A block placed in a dug hole can no longer block the upgrade. - **Old casinos:** the upgrade check uses the stored zone box as the current building. Before, player blocks above an old, lower casino were not counted and were silently cleared, because the new templates are taller. - **Stairs:** the staircase now ends level with the second floor (one more step in the ceiling layer, with headroom kept). Players and villagers no longer need to jump at the top. - **Snowy upper floor:** with a second floor, the hall ceiling uses floor material. The snowy upper floor was packed ice. - **Sign names:** the "Hot:" sign line uses short game names (e.g. "Jackpot", "Hi-Lo"), so they fit on the sign. - **Sneak peek:** the 1-2 star sneak peek only replaces a machine that has a twin, so no game of the star goes missing. ## Improvement - **Placement retries:** each retry looks at other spots (the distance shifts by one and the spread along the village edge grows), and 16 blocks was added as a last distance. Fewer villages should end up without a casino now that the full 5-star site is required. ## Not tested in game Gradle can't reach maven.neoforged.net from the build container. Checked with the generator's validation, the javac syntax check, `build_assets.sh` and `check_trees.py`. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01MfH3NBzVMUijPYLmpAUPwK
Village casinos: fixes from review
Some checks failed
Build / build (push) Failing after 13m42s
Build / build (pull_request) Failing after 13m50s
fcdb8154f1
- A player casino zone can no longer be registered on the ground a village casino grows
  into (it blocked the upgrade forever); new village casinos also keep clear of the
  frame of a neighbouring village's casino.
- The reserved ground now reaches 3 blocks below the floor, like the upgrade check, so a
  block placed in a dug hole cannot block the upgrade.
- Upgrade check uses the stored zone box as the current building, so player blocks above
  an old (lower) casino are no longer cleared silently.
- Placement retries look at other spots (distance shift, wider spread) and also try 16.
- Staircase ends level with the second floor (one more step), no jump at the top.
- With a second floor the hall ceiling is floor material (snowy upper floor was packed ice).
- Short game names on the 'Hot:' sign line.
- The 1-2 star sneak peek only replaces a machine that has a twin.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MfH3NBzVMUijPYLmpAUPwK
SteamPodEater changed target branch from village-casino-second-floor to main 2026-11-10 09:05:06 +00:00
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
SteamPodEater/MakeItRoll!8
No description provided.