Version dropdowns, mod version switching, and never sending mods that would stop the game #5
No reviewers
Labels
No labels
accessibility
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
Bewerkt/ManageMC!5
Loading…
Reference in a new issue
No description provided.
Delete branch "claude/minecraft-mod-manager-h5capw"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What changes
Version dropdowns
GET /api/admin/versions.LoaderVersionResolverbecameVersionCatalog.Change or remove mods from the search results
GET …/mods/:id/versionsandPOST …/mods/:id/version. Only versions of the mod's own project are accepted.Never send mods that would stop the game from starting (found while testing the NeoForge→Fabric switch)
Problem: Fabric and NeoForge check every mod before any mod runs, ManageMC included. A mod for the other loader, or one whose dependency is missing, crashes the game at start, and ManageMC can then never deliver a fix. The usual case is Fabric API: Fabric builds of mods need it, and Modrinth often doesn't list it as a dependency.
Jar inspector: reads required dependencies and provided ids per loader, size- and depth-capped:
fabric.mod.jsondepends/provides;neoforge.mods.tomlrequired dependencies (type="required"ormandatory=true);META-INF/jars,META-INF/jarjar), so Fabric API's modules count as provided.The result is stored per mod (migration 5), and existing mods are read on startup.
Pack health: mods for another loader, and mods with missing dependencies (repeated until stable), are withheld from the manifest, so the pack always starts.
Mods tab: a problems panel with "Choose version", "Add from Modrinth" (Fabric API modules map to Fabric API) and Fix automatically. Fix automatically switches linked mods to the pack's loader and adds missing dependencies from Modrinth. Withheld mods are marked "Not sent".
Adding from Modrinth: also adds dependencies the jar requires but the platform does not list.
Limitation: version ranges are not evaluated, only presence.
Tests
🤖 Generated with Claude Code
https://claude.ai/code/session_016zdMyacgAzBQEBSiHc6aZJ